linux-kernel - Re: [PATCH v2] staging: rtl8188eu: remove not necessary braces {} (checkpatch fix)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 1 Feb 2017 18:36:00 +0200
From:   Martin Karamihov <martinowar@...il.com>
To:     Joe Perches <joe@...ches.com>, gregkh@...uxfoundation.org
Cc:     Larry.Finger@...inger.net, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] staging: rtl8188eu: remove not necessary braces {}
 (checkpatch fix)



On 02/01/2017 12:39 AM, Joe Perches wrote:
> On Tue, 2017-01-31 at 21:24 +0200, Martin Karamihov wrote:
>> This is checkpatch fix for hal/bb_cfg.c file:
>> remove not necessary braces {}
>>
>> Signed-off-by: Martin Karamihov <martinowar@...il.com>
>> ---
>>   drivers/staging/rtl8188eu/hal/bb_cfg.c | 3 +--
>>   1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/rtl8188eu/hal/bb_cfg.c b/drivers/staging/rtl8188eu/hal/bb_cfg.c
>> index 134fa6c595a8..26e0ef224299 100644
>> --- a/drivers/staging/rtl8188eu/hal/bb_cfg.c
>> +++ b/drivers/staging/rtl8188eu/hal/bb_cfg.c
>> @@ -534,9 +534,8 @@ static void store_pwrindex_offset(struct adapter *adapter,
>>   		power_level_offset[11] = data;
>>   	if (regaddr == rTxAGC_B_Mcs11_Mcs08)
>>   		power_level_offset[12] = data;
>> -	if (regaddr == rTxAGC_B_Mcs15_Mcs12) {
>> +	if (regaddr == rTxAGC_B_Mcs15_Mcs12)
>>   		power_level_offset[13] = data;
>> -	}
> presumably, this and the regaddr block above it
> should be an else if or a switch/case.
>
>

I will prepare the patch if this code modification is needed right now. 
Is it?