linux-kernel - Re: [PATCH] [RFC] sched: make DECLARE_COMPLETION

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK8P3a0uo5gpDJ-u6OeG4rAXg+BaXcz7CVcY9rR=n826m=2XMQ@mail.gmail.com>
Date:   Wed, 1 Feb 2017 17:38:16 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Cc:     linux-mm@...ck.org, Arnd Bergmann <arnd@...db.de>,
        Ingo Molnar <mingo@...e.hu>
Subject: Re: [PATCH] [RFC] sched: make DECLARE_COMPLETION_ONSTACK() work with clang

On Wed, Feb 1, 2017 at 5:34 PM, Arnd Bergmann <arnd@...db.de> wrote:

> diff --git a/include/linux/completion.h b/include/linux/completion.h
> index fa5d3efaba56..5d5aaae3af43 100644
> --- a/include/linux/completion.h
> +++ b/include/linux/completion.h
> @@ -31,7 +31,7 @@ struct completion {
>         { 0, __WAIT_QUEUE_HEAD_INITIALIZER((work).wait) }
>
>  #define COMPLETION_INITIALIZER_ONSTACK(work) \
> -       (*init_completion(&work))
> +       ({ init_completion(&work); work; })
>
>  /**
>   * DECLARE_COMPLETION - declare and initialize a completion structure
> @@ -70,11 +70,10 @@ struct completion {
>   * This inline function will initialize a dynamically created completion
>   * structure.
>   */
> -static inline struct completion *init_completion(struct completion *x)
> +static inline void init_completion(struct completion *x)
>  {
>         x->done = 0;
>         init_waitqueue_head(&x->wait);
> -       return x;
>  }
>

I accidentally submitted the wrong patch, this is the revert of the
actual change.

       Arnd