linux-kernel - Re: Fwd: Re: [tpmdd-devel] [PATCH v9 2/2] tpm: add securityfs support,for TPM 2.0 firmware event log

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170201182346.az2nkssotenb4i5m@intel.com>
Date:   Wed, 1 Feb 2017 20:23:46 +0200
From:   Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To:     Mimi Zohar <zohar@...ux.vnet.ibm.com>
Cc:     James Morris <jmorris@...ei.org>,
        Kenneth Goldman <kgoldman@...ibm.com>,
        "moderated list:TPM DEVICE DRIVER" 
        <tpmdd-devel@...ts.sourceforge.net>,
        open list <linux-kernel@...r.kernel.org>,
        linux-security-module@...r.kernel.org
Subject: Re: Fwd: Re: [tpmdd-devel] [PATCH v9 2/2] tpm: add securityfs
 support,for TPM 2.0 firmware event log

On Wed, Feb 01, 2017 at 08:49:30AM -0500, Mimi Zohar wrote:
> On Wed, 2017-02-01 at 12:30 +0200, Jarkko Sakkinen wrote:
> > On Tue, Jan 31, 2017 at 05:31:50PM -0500, Mimi Zohar wrote:
> > > On Wed, 2017-02-01 at 08:46 +1100, James Morris wrote:
> > > > On Tue, 31 Jan 2017, Jarkko Sakkinen wrote:
> > > > 
> > > > > James,
> > > > > 
> > > > > The discussion is about two features:
> > > > > 
> > > > > 1. Extension to tpm_pcr_extend() (used by IMA) to extend all PCR banks
> > > > >    instead of just SHA-1 banks. It is recommended by TCG to do so in
> > > > >    order to prevent malicious use of PCRs.
> > > > > 2. TPM 2.0 event log with backend support for OF device tree (for
> > > > >    getting address where you can grab it).
> > > > > 
> > > > > These are required as baseline to implement full TPM 2.0 support for
> > > > > IMA. The commits are fairly well baked and went through many iterations.
> > > > > I've tested tpm_pcr_extend() patches. I haven't tested event log patches
> > > > > but have extensively reviewed them and Ken Goldman has tested them with
> > > > > POWER hardware.
> > > > > 
> > > > > I don't believe that there is major risk to put them already into 4.11
> > > > > but it is fairly late so I just want a second opinion before putting
> > > > > them into pull request.
> > > > > 
> > > > 
> > > > I'll take this for 4.11.  IMA + TPM 2.0 is still developmental and not in 
> > > > wide use, afaik.
> > > 
> > > Thank you!   FYI, I've been running with them as well.
> > > 
> > > Mimi
> > 
> > OK, so can I also add your Tested-by to these four commits?
> 
> I provided Ken with the firmware event log, IMA measurement list, and
> the PCRs for testing.   Ken's tested-by is fine.  Missing is Stefan's
> tested-by - https://sourceforge.net/p/tpmdd/mailman/message/35602588/
> I would really appreciate your adding his tested-by.
> 
> thanks,
> 
> Mimi

Sure, I'll add it.

/Jarkko