linux-kernel - Re: [PATCH] phy: qcom-usb-hs: Add depends on EXTCON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <148597526575.11383.16198703484869555373@sboyd-linaro>
Date:   Wed, 01 Feb 2017 10:54:25 -0800
From:   Stephen Boyd <stephen.boyd@...aro.org>
To:     Kishon Vijay Abraham I <kishon@...com>, gregkh@...uxfoundation.org
Cc:     linux-kernel@...r.kernel.org, Arnd Bergmann <arnd@...db.be>
Subject: Re: [PATCH] phy: qcom-usb-hs: Add depends on EXTCON

Quoting Kishon Vijay Abraham I (2017-02-01 00:27:44)
> commit e2427b09ba929c2b9 (phy: Add support for Qualcomm's USB HS phy")
> while using extcon API's in qcom-usb-hs failed to add
> 'depends on EXTCON' resulting in the following compile errors if
> EXTCON is not enabled.
> drivers/built-in.o: In function `qcom_usb_hs_phy_power_off':
> phy-qcom-usb-hs.c:(.text+0x1089): undefined reference to `extcon_unregister_notifier'
> drivers/built-in.o: In function `qcom_usb_hs_phy_probe':
> phy-qcom-usb-hs.c:(.text+0x11b5): undefined reference to `extcon_get_edev_by_phandle'
> drivers/built-in.o: In function `qcom_usb_hs_phy_power_on':
> phy-qcom-usb-hs.c:(.text+0x128e): undefined reference to `extcon_get_state'
> phy-qcom-usb-hs.c:(.text+0x12a9): undefined reference to `extcon_register_notifier'
> 
> Fix it here.
> 
> Fixes: 9994a33865f4 e2427b09ba929c2b9 (phy: Add support for Qualcomm's USB
> HS phy")
> 
> Cc: Stephen Boyd <stephen.boyd@...aro.org>
> Signed-off-by: Kishon Vijay Abraham I <kishon@...com>

The extcon is optional in the binding, so "depends on EXTCON" is
incorrect.  It should follow the modular or non-modular nature of extcon
if extcon is enabled and still compile if extcon is disabled. So 
we want this instead. Care to replace it with this patch?

----8<----
diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
index bb5cf6f49b06..3c2822457784 100644
--- a/drivers/phy/Kconfig
+++ b/drivers/phy/Kconfig
@@ -441,6 +441,7 @@ config PHY_QCOM_UFS
 config PHY_QCOM_USB_HS
 	tristate "Qualcomm USB HS PHY module"
 	depends on USB_ULPI_BUS
+	depends on EXTCON || !EXTCON # if EXTCON=m, this cannot be built-in
 	select GENERIC_PHY
 	help
 	  Support for the USB high-speed ULPI compliant phy on Qualcomm