linux-kernel - Re: [PATCH] fscrypt: properly declare on-stack completion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <225430ef-9f08-bde3-4ad3-78d41b0464d2@nod.at>
Date:   Wed, 1 Feb 2017 21:34:09 +0100
From:   Richard Weinberger <richard@....at>
To:     linux-fsdevel@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, jaegeuk@...nel.org,
        Theodore Ts'o <tytso@....edu>, ebiggers@...gle.com,
        david@...ma-star.at
Subject: Re: [PATCH] fscrypt: properly declare on-stack completion

Am 01.02.2017 um 21:32 schrieb Richard Weinberger:
> When a completion is declared on-stack we have to use
> COMPLETION_INITIALIZER_ONSTACK().
> 
> Fixes: 0b81d07790726 ("fs crypto: move per-file encryption from f2fs
> tree to fs/crypto")
> Signed-off-by: Richard Weinberger <richard@....at>
> 
> ---
>  fs/crypto/fscrypt_private.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/crypto/fscrypt_private.h b/fs/crypto/fscrypt_private.h
> index aeab032d7d35..a0494a164f97 100644
> --- a/fs/crypto/fscrypt_private.h
> +++ b/fs/crypto/fscrypt_private.h
> @@ -81,7 +81,7 @@ struct fscrypt_completion_result {
>  
>  #define DECLARE_FS_COMPLETION_RESULT(ecr) \
>  	struct fscrypt_completion_result ecr = { \
> -		COMPLETION_INITIALIZER((ecr).completion), 0 }
> +		COMPLETION_INITIALIZER_ONSTACK((ecr).completion), 0 }
>  
>  
>  /* crypto.c */
> 

Replying with Ted's corrected mail address... ;-\

Thanks,
//richard