linux-kernel - Re: [PATCH v2 4/4] perf tools: Increase index if perf_evsel__new

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9657c22b-bbd3-a41a-7b92-622004b76a98@gmail.com>
Date:   Wed, 1 Feb 2017 17:04:46 +0900
From:   Taeung Song <treeze.taeung@...il.com>
To:     Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>
Cc:     linux-kernel@...r.kernel.org, Jiri Olsa <jolsa@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Wang Nan <wangnan0@...wei.com>
Subject: Re: [PATCH v2 4/4] perf tools: Increase index if
 perf_evsel__new_idx() succeeded



On 01/31/2017 10:25 PM, Arnaldo Carvalho de Melo wrote:
> Em Tue, Jan 31, 2017 at 08:38:31PM +0900, Taeung Song escreveu:
>> Cc: Jiri Olsa <jolsa@...nel.org>
>> Cc: Namhyung Kim <namhyung@...nel.org>
>> Signed-off-by: Taeung Song <treeze.taeung@...il.com>
>
> The title of this patch is misleading, ambiguous. It leads one to have
> doubt if we were not incrementing that index before and now we are,
> after successfully calling perf_evsel__new_idx().
>
> It should have been:
>
>   "perf tools: Only increase index if perf_evsel__new_idx() succeeds"
>

Understood!
I'll change the title!

Thanks,
Taeung