lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 02 Feb 2017 19:55:09 +1030 From: Rusty Russell <rusty@...tcorp.com.au> To: Arnd Bergmann <arnd@...db.de>, Jessica Yu <jeyu@...hat.com> Cc: Arnd Bergmann <arnd@...db.de>, Jiri Kosina <jikos@...nel.org>, Paul Gortmaker <paul.gortmaker@...driver.com>, Miroslav Benes <mbenes@...e.cz>, Anson Jacob <ansonjacob.aj@...il.com>, linux-kernel@...r.kernel.org Subject: Re: [PATCH] modules: mark __inittest/__exittest as __maybe_unused Arnd Bergmann <arnd@...db.de> writes: > clang warns about unused inline functions by default: > > arch/arm/crypto/aes-cipher-glue.c:68:1: warning: unused function '__inittest' [-Wunused-function] > arch/arm/crypto/aes-cipher-glue.c:69:1: warning: unused function '__exittest' [-Wunused-function] > > As these appear in every single module, let's just disable the warnings by marking the > two functions as __maybe_unused. Um, won't you have to do that to hundreds of kernel headers? Why module.h? Confused, Rusty. > Signed-off-by: Arnd Bergmann <arnd@...db.de> > --- > include/linux/module.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/linux/module.h b/include/linux/module.h > index 38b4b2c754c8..48a5c57c858e 100644 > --- a/include/linux/module.h > +++ b/include/linux/module.h > @@ -126,13 +126,13 @@ extern void cleanup_module(void); > > /* Each module must use one module_init(). */ > #define module_init(initfn) \ > - static inline initcall_t __inittest(void) \ > + static inline initcall_t __maybe_unused __inittest(void) \ > { return initfn; } \ > int init_module(void) __attribute__((alias(#initfn))); > > /* This is only required if you want to be unloadable. */ > #define module_exit(exitfn) \ > - static inline exitcall_t __exittest(void) \ > + static inline exitcall_t __maybe_unused __exittest(void) \ > { return exitfn; } \ > void cleanup_module(void) __attribute__((alias(#exitfn))); > > -- > 2.9.0
Powered by blists - more mailing lists