linux-kernel - Re: [PATCH 2/2] net: ethernet: bgmac: mac address change bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 2 Feb 2017 12:49:59 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Jon Mason <jon.mason@...adcom.com>,
        David Miller <davem@...emloft.net>
Cc:     rafal@...ecki.pl, bcm-kernel-feedback-list@...adcom.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        Hari Vyas <hariv@...adcom.com>
Subject: Re: [PATCH 2/2] net: ethernet: bgmac: mac address change bug

On 2/2/2017 1:39 AM, Jon Mason wrote:

> From: Hari Vyas <hariv@...adcom.com>
>
> ndo_set_mac_address() passes struct sockaddr * as 2nd parameter to
> bgmac_set_mac_address() but code assumed u8 *.  This caused two bytes
> chopping and the wrong mac address was configured.
>
> Signed-off-by: Hari Vyas <hariv@...adcom.com>
> Signed-off-by: Jon Mason <jon.mason@...adcom.com>
> Fixes: 4e209001b86 ("bgmac: write mac address to hardware in ndo_set_mac_address")
> ---
>  drivers/net/ethernet/broadcom/bgmac.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/broadcom/bgmac.c b/drivers/net/ethernet/broadcom/bgmac.c
> index 0e066dc6..ea24072 100644
> --- a/drivers/net/ethernet/broadcom/bgmac.c
> +++ b/drivers/net/ethernet/broadcom/bgmac.c
> @@ -1222,11 +1222,15 @@ static int bgmac_set_mac_address(struct net_device *net_dev, void *addr)
>  {
>  	struct bgmac *bgmac = netdev_priv(net_dev);
>  	int ret;
> +	struct sockaddr *sa = addr;

    DaveM prefers the declarations to be arranged from longest to shortest.

[...]

MBR, Sergei