linux-kernel - Re: [PATCH] platform/x86: silead depends on I2C being built-in

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 2 Feb 2017 17:24:51 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Hans de Goede <hdegoede@...hat.com>
Cc:     Arnd Bergmann <arnd@...db.de>, Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] platform/x86: silead depends on I2C being built-in

On Thu, Feb 2, 2017 at 5:10 PM, Hans de Goede <hdegoede@...hat.com> wrote:
> On 02-02-17 16:01, Andy Shevchenko wrote:
>> On Thu, Feb 2, 2017 at 4:45 PM, Hans de Goede <hdegoede@...hat.com> wrote:

>>> Thank you.
>>>
>>> Acked-by: Hans de Goede <hdegoede@...hat.com>
>>
>>
>> I'm a bit confused now:
>>
>> http://www.spinics.net/lists/platform-driver-x86/msg10408.html
>>
>> Please, clarify.
>
> The depends on INPUT is not entirely wrong, the module does not
> need it, but without the SILEAD driver being build the silead_dmi
> code is of no use. Since multiple people already reported this
> I thought it would be best to just go ahead with Arnd's version.

Thanks, pushed to testing.

-- 
With Best Regards,
Andy Shevchenko