linux-kernel - Re: [PATCH] reset: make zx2967 explicitly non-modular

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 02 Feb 2017 16:35:19 +0100
From:   Philipp Zabel <p.zabel@...gutronix.de>
To:     Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:     linux-kernel@...r.kernel.org, Jun Nie <jun.nie@...aro.org>,
        Baoyou Xie <baoyou.xie@...aro.org>
Subject: Re: [PATCH] reset: make zx2967 explicitly non-modular

On Thu, 2017-02-02 at 09:52 -0500, Paul Gortmaker wrote:
> The Kconfig currently controlling compilation of this code is:
> 
>    config RESET_ZX2967
>           bool "ZTE ZX2967 Reset Driver
> 
> ...meaning that it currently is not being built as a module by anyone.
> 
> Lets remove the couple traces of modular infrastructure use, so that
> when reading the driver there is no doubt it is builtin-only.
> 
> Since builtin_platform_driver() was already in use, the init ordering
> remains unchanged with this commit.
> 
> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
> 
> We also delete the MODULE_LICENSE tag etc. since all that information
> is already contained at the top of the file in the comments.
> 
> We don't replace module.h with init.h since the file does not appear
> to use __init prefix anywhere.
> 
> Cc: Jun Nie <jun.nie@...aro.org>
> Cc: Baoyou Xie <baoyou.xie@...aro.org>
> Cc: Philipp Zabel <p.zabel@...gutronix.de>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>

Thank you, applied with Baoyou's Reviewed-by.

regards
Philipp