linux-kernel - Re: [PATCH 2/4] mm: Fix checkpatch warnings, whitespace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 2 Feb 2017 14:51:17 +1100
From:   Tobin Harding <me@...in.cc>
To:     David Rientjes <rientjes@...gle.com>
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
        Jan Kara <jack@...e.cz>,
        Ross Zwisler <ross.zwisler@...ux.intel.com>,
        Michal Hocko <mhocko@...e.com>
Subject: Re: [PATCH 2/4] mm: Fix checkpatch warnings, whitespace

On Wed, Feb 01, 2017 at 04:48:28PM -0800, David Rientjes wrote:
> On Thu, 2 Feb 2017, Tobin C. Harding wrote:
> 
> > @@ -3696,8 +3695,8 @@ int handle_mm_fault(struct vm_area_struct *vma, unsigned long address,
> >                   * VM_FAULT_OOM), there is no need to kill anything.
> >                   * Just clean up the OOM state peacefully.
> >                   */
> > -                if (task_in_memcg_oom(current) && !(ret & VM_FAULT_OOM))
> > -                        mem_cgroup_oom_synchronize(false);
> > +		if (task_in_memcg_oom(current) && !(ret & VM_FAULT_OOM))
> > +			mem_cgroup_oom_synchronize(false);
> >  	}
> >  
> >  	/*
> 
> The comment suffers from the same problem.

The comment is fixed in the next patch of the set. The fixes are in
separate patches because one was a checkpatch warning and one was an
error.

Any comments on the structure of the patchset most appreciated.


thanks,
Tobin.