linux-kernel - Re: [PATCH] modules: mark __inittest/__exittest as __maybe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 2 Feb 2017 20:44:56 +0100 (CET)
From:   Miroslav Benes <mbenes@...e.cz>
To:     Arnd Bergmann <arnd@...db.de>
cc:     Jessica Yu <jeyu@...hat.com>,
        Rusty Russell <rusty@...tcorp.com.au>,
        Jiri Kosina <jikos@...nel.org>,
        Paul Gortmaker <paul.gortmaker@...driver.com>,
        Anson Jacob <ansonjacob.aj@...il.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] modules: mark __inittest/__exittest as __maybe_unused

On Wed, 1 Feb 2017, Arnd Bergmann wrote:

> clang warns about unused inline functions by default:
> 
> arch/arm/crypto/aes-cipher-glue.c:68:1: warning: unused function '__inittest' [-Wunused-function]
> arch/arm/crypto/aes-cipher-glue.c:69:1: warning: unused function '__exittest' [-Wunused-function]
> 
> As these appear in every single module, let's just disable the warnings by marking the
> two functions as __maybe_unused.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Makes sense.

Reviewed-by: Miroslav Benes <mbenes@...e.cz>

Regards,
Miroslav