linux-kernel - Re: [PATCH v4 2nd 1/4] ramoops: Add __ramoops_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 2 Feb 2017 14:13:09 -0800
From:   Mark Salyzyn <salyzyn@...roid.com>
To:     Nobuhiro Iwamatsu <nobuhiro.iwamatsu.kw@...achi.com>,
        Anton Vorontsov <anton@...msg.org>,
        Colin Cross <ccross@...roid.com>,
        Kees Cook <keescook@...omium.org>,
        Tony Luck <tony.luck@...el.com>
Cc:     linux-kernel@...r.kernel.org,
        Hiraku Toyooka <hiraku.toyooka.gu@...achi.com>,
        Seiji Aguchi <seiji.aguchi.tr@...achi.com>,
        Shuah Khan <shuahkh@....samsung.com>
Subject: Re: [PATCH v4 2nd 1/4] ramoops: Add __ramoops_init_prz() as generic
 function

On 01/30/2017 05:58 PM, Nobuhiro Iwamatsu wrote:
> +
> +	if (zap && *paddr + sz - cxt->phys_addr > cxt->size) {
> +		dev_err(dev, "no room for %s mem region (0x%zx@...llx) in (0x%lx@...llx)\n",
> +			name, sz, (unsigned long long)*paddr,
> +			cxt->size, (unsigned long long)cxt->phys_addr);
> +		return -ENOMEM;
> +	}
> +
Why not allow this limit check for ramoops_init_prsz call?

-- Mark