linux-kernel - Re: [PATCH v2] staging: rtl8188eu: remove not necessary braces {} (checkpatch fix)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 02 Feb 2017 15:32:56 -0800
From:   Joe Perches <joe@...ches.com>
To:     Martin Karamihov <martinowar@...il.com>, gregkh@...uxfoundation.org
Cc:     Larry.Finger@...inger.net, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] staging: rtl8188eu: remove not necessary braces {}
 (checkpatch fix)

On Thu, 2017-02-02 at 08:06 +0200, Martin Karamihov wrote:
> On 02/01/2017 08:11 PM, Joe Perches wrote:
> > ...and clarifying the code for a
> > human reader is much more important than making a
> > file not have any checkpatch warnings.
> 
> I agree. I respect the developers' own coding style and believe that 
> some things (>80 characters long lines, name conventions, etc) should be 
> fixed by themselves (if they want to do that). I selected several TODOs 
> with requests for code cleanups and chose a fix in attempt to accomplish 
> my task with minimal inconvenience for the maintainers. I failed in my 
> first attempts breaking some basic rules, sorry about that.

No, not at all.  You did fine for a basic checkpatch cleanup.
I just wanted to tell you to think beyond checkpatch.

cheers, Joe