linux-kernel - Re: [PATCH v2] staging: rtl8188eu: remove not necessary braces {} (checkpatch fix)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 2 Feb 2017 08:06:52 +0200
From:   Martin Karamihov <martinowar@...il.com>
To:     Joe Perches <joe@...ches.com>, gregkh@...uxfoundation.org
Cc:     Larry.Finger@...inger.net, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] staging: rtl8188eu: remove not necessary braces {}
 (checkpatch fix)

On 02/01/2017 08:11 PM, Joe Perches wrote:
> ...and clarifying the code for a
> human reader is much more important than making a
> file not have any checkpatch warnings.

I agree. I respect the developers' own coding style and believe that 
some things (>80 characters long lines, name conventions, etc) should be 
fixed by themselves (if they want to do that). I selected several TODOs 
with requests for code cleanups and chose a fix in attempt to accomplish 
my task with minimal inconvenience for the maintainers. I failed in my 
first attempts breaking some basic rules, sorry about that.

Martin