linux-kernel - Re: [PATCH v3 1/1] x86, relocs: add printf attribute to die()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 2 Feb 2017 08:16:00 +0100
From:   Ingo Molnar <mingo@...nel.org>
To:     Nicolas Iooss <nicolas.iooss_linux@....org>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/1] x86, relocs: add printf attribute to die()


* Nicolas Iooss <nicolas.iooss_linux@....org> wrote:

> With %Ld, my compiler (gcc 6.3.1 on x86_64) complains:
> 
> arch/x86/tools/relocs.c:400:7: error: format ‘%Ld’ expects argument of
> type ‘long long int’, but argument 2 has type ‘Elf64_Off {aka long
> unsigned int}’ [-Werror=format=]

How did it pick up that type as an 'unsigned long'? We have:

  include/uapi/linux/elf.h:typedef __u64  Elf64_Off;

Even user-space has it as a pure 64-bit type:

  /usr/include/elf.h:typedef uint64_t Elf64_Off;

Thanks,

	Ingo