linux-kernel - Re: [PATCH V7 3/4] drm/bridge: Add driver for GE B850v3 LVDS/DP++ Bridge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 3 Feb 2017 09:00:40 +0100
From:   Daniel Vetter <daniel@...ll.ch>
To:     Emil Velikov <emil.l.velikov@...il.com>
Cc:     Peter Senna Tschudin <peter.senna@...labora.co.uk>,
        Mark Rutland <mark.rutland@....com>,
        martyn.welch@...labora.co.uk, peter.senna@...il.com,
        ML dri-devel <dri-devel@...ts.freedesktop.org>,
        "Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>,
        Yakir Yang <ykk@...k-chips.com>, Jiri Slaby <jslaby@...e.cz>,
        Mauro Carvalho Chehab <mchehab@....samsung.com>,
        Russell King - ARM Linux <linux@...linux.org.uk>,
        Peter Senna Tschudin <peter.senna@...labora.com>,
        javier@...hile0.org, Thierry Reding <treding@...dia.com>,
        Guenter Roeck <linux@...ck-us.net>, martin.donnelly@...com,
        devicetree <devicetree@...r.kernel.org>,
        Pawel Moll <pawel.moll@....com>,
        Ian Campbell <ijc+devicetree@...lion.org.uk>,
        Fabio Estevam <fabio.estevam@....com>,
        Russell King <rmk+kernel@...linux.org.uk>,
        Rob Herring <robh+dt@...nel.org>,
        LAKML <linux-arm-kernel@...ts.infradead.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        tiwai@...e.com, Sascha Hauer <kernel@...gutronix.de>,
        Kumar Gala <galak@...eaurora.org>,
        Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Shawn Guo <shawnguo@...nel.org>,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH V7 3/4] drm/bridge: Add driver for GE B850v3 LVDS/DP++
 Bridge

On Thu, Feb 02, 2017 at 12:37:21PM +0000, Emil Velikov wrote:
>  - Daniel, gents - is drm-misc aimed at devs with limited (no?)
> review/commit history in the area and/or the kernel in general ?
> In this case, Peter have quite noticeable experience [in kernel
> development] with little-to no in DRM.
> Should one draw a line in the sand somewhere ?

We're fairly lenient with accepting new drivers already, and for drivers
in drm-misc we require some checks and peer review to make sure new folks
learn faster. But it's an expirement, I fully expect some fallout and then
some learnign and fine tuning from that, and maybe we even need to crank
requirements back up to a much higher level of experience.

But for drivers I'm honestly not too concerned: As long as there's some
process in place to foster learning&collaboration (which I think will be
better with this) I really don't see much harm in merging non-perfect
driver code.

>  - You patch has been on a long [bit rocky road] for a while, with
> devs giving you [what seems like] a partial reviews.
> Have you considered reviewing others' patches in exchange for a [more
> complete one] of this one ? According to git log people have poked you
> a handful of times, but seemingly you were busy.

Just a clarification: When I review drivers I don't do a fairly cursor
look, hunting for areas where some refactoring and align with drm best
practices would be good. And I think that's perfectly fine and enough to
get a driver landed, but we're definitely not 100% consistent on this
within drm-misc. Probably will take some time to figure this out.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch