linux-kernel - Re: [PATCH v6: 2/4] x86: Add enabling of the R3MWAIT during boot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 3 Feb 2017 11:47:40 +0100
From:   Pavel Machek <pavel@....cz>
To:     "Andrejczuk, Grzegorz" <grzegorz.andrejczuk@...el.com>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "hpa@...or.com" <hpa@...or.com>, "x86@...nel.org" <x86@...nel.org>,
        "bp@...e.de" <bp@...e.de>,
        "dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
        "Daniluk, Lukasz" <lukasz.daniluk@...el.com>,
        "Cownie, James H" <james.h.cownie@...el.com>,
        "Pan, Jacob jun" <jacob.jun.pan@...el.com>,
        "Luc, Piotr" <Piotr.Luc@...el.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v6: 2/4] x86: Add enabling of the R3MWAIT during boot

On Fri 2016-12-09 12:49:33, Andrejczuk, Grzegorz wrote:
> > > On Thu 2016-10-27 16:38:13, Thomas Gleixner wrote:
> > > > On Thu, 27 Oct 2016, Grzegorz Andrejczuk wrote:
> > > > > +#ifdef CONFIG_X86_64
> > > > > +static int phi_r3mwait_disabled __read_mostly;
> > > > > +
> > > > > +static int __init phir3mwait_disable(char *__unused) {
> > > > > +	phi_r3mwait_disabled = 1;
> > > > > +	pr_warn("x86/phir3mwait: Disabled ring 3 MWAIT for Xeon Phi");
> > > > 
> > > > Why would that be a warning? The sysadmin added the command line 
> > > > switch, so why does he needs to be warned?
> > > 
> > > Its telling admin he did not make a typo on the command line. We often do that....
> >
> > Definitely not at the warning level.
> 
> Is info level OK for that message?

I'd say so.
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)