linux-kernel - Re: [PATCH] [linux-next] staging: greybus: Remove duplicate include file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170203124317.GD12545@localhost>
Date:   Fri, 3 Feb 2017 13:43:17 +0100
From:   Johan Hovold <johan@...nel.org>
To:     Masanari Iida <standby24x7@...il.com>
Cc:     johan@...nel.org, elder@...nel.org, gregkh@...uxfoundation.org,
        linux-kernel@...r.kernel.org, greybus-dev@...ts.linaro.org
Subject: Re: [PATCH] [linux-next] staging: greybus: Remove duplicate include
 file

On Wed, Feb 01, 2017 at 08:05:07PM +0900, Masanari Iida wrote:
> This patch removed duplicated include line.
> 
> Signed-off-by: Masanari Iida <standby24x7@...il.com>
> ---
>  drivers/staging/greybus/authentication.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/staging/greybus/authentication.c b/drivers/staging/greybus/authentication.c
> index 168626ba0c03..6c5dcb1c226b 100644
> --- a/drivers/staging/greybus/authentication.c
> +++ b/drivers/staging/greybus/authentication.c
> @@ -16,7 +16,6 @@
>  
>  #include "greybus_authentication.h"
>  #include "firmware.h"
> -#include "greybus.h"

Please remove the other "greybus.h" include that precedes the "system"
includes instead.

>  
>  #define CAP_TIMEOUT_MS		1000

Also add a component prefix to your subject (i.e. "staging: greybus:
authentication: remove...").

Thanks,
Johan