linux-kernel - Re: [PATCH v9 4/4] console: Make persistent scrollback a boot parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 03 Feb 2017 17:04:15 +0100
From:   Manuel Schölling <manuel.schoelling@....de>
To:     Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:     "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        jslaby@...e.com, kilobyte@...band.pl, lkml14@...tdoyle.com,
        rdunlap@...radead.org, shorne@...il.com, andrey_utkin@...tmail.com,
        Andrew Morton <akpm@...ux-foundation.org>,
        paul.burton@...tec.com, daniel.vetter@...ll.ch, tj@...nel.org,
        hdegoede@...hat.com, LKML <linux-kernel@...r.kernel.org>,
        linux-fbdev@...r.kernel.org
Subject: Re: [PATCH v9 4/4] console: Make persistent scrollback a boot
 parameter

Hi Paul,

On Thu, 2017-02-02 at 15:07 -0500, Paul Gortmaker wrote:
> On Tue, Jan 10, 2017 at 4:28 PM, Manuel Schölling
> <manuel.schoelling@....de> wrote:
> > The impact of the persistent scrollback feature on the code size is
> > rather small, so the config option is removed. The feature stays
> > disabled by default and can be enabled by using the boot command
> > line
> > parameter 'vgacon.scrollback_persistent=1' or by setting
> > VGACON_SOFT_SCROLLBACK_PERSISTENT_ENABLE_BY_DEFAULT=y.
> > 
> > Signed-off-by: Manuel Schölling <manuel.schoelling@....de>
> > Suggested-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
> > ---
> 
> [...]
> 
> > +module_param_named(scrollback_persistent, scrollback_persistent,
> > bool, 0000);
> > +MODULE_PARM_DESC(scrollback_persistent, "Enable persistent
> > scrollback for all vga consoles");
> 
> Since this hasn't got widespread deployment yet and  only exists
> in Greg's tree, can we please fix the above to use setup_param or
> similar, since there is nothing modular about this code at all.
Not sure what you mean here.
If this is not the right may to declare it I'd be more than happy to
change this. But I could not find any function/macro named setup_param
[1].
It would be great if you could give me a hint what function to use
here!

Have a great weekend!

Manuel

[1] http://lxr.free-electrons.com/ident?i=setup_param