linux-kernel - Re: [PATCH] net: phy: dp83867: Fix for automatically detected PHYs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170203171031.GC15900@lunn.ch>
Date:   Fri, 3 Feb 2017 18:10:31 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Alexey Brodkin <Alexey.Brodkin@...opsys.com>
Cc:     netdev@...r.kernel.org, linux-snps-arc@...ts.infradead.org,
        linux-kernel@...r.kernel.org,
        Murali Karicheri <m-karicheri2@...com>,
        Sekhar Nori <nsekhar@...com>,
        "David S . Miller" <davem@...emloft.net>,
        Grygorii Strashko <grygorii.strashko@...com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Mugunthan V N <mugunthanvnm@...com>
Subject: Re: [PATCH] net: phy: dp83867: Fix for automatically detected PHYs

On Fri, Feb 03, 2017 at 07:52:37PM +0300, Alexey Brodkin wrote:
> Current implemntation returns ENODEV if device tree node for
> phy is absent. But in reality there're many boards with the one
> and only PHY on board and MACs that may find a PHY by querying
> MDIO bus. One good example is STMMAC.

Humm, not so sure about that. That check for an OF node has always
been there, since day one for this driver.

What has changed recently is where it looks for these device tree
properties. It used to wrongly look in the MAC node. It was changed to
look in the PHY node. So this is probably the reason you are having
problems.

Having said that, your patch looks O.K.

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew