linux-kernel - Re: [PATCH v2 4/8] arm: set CONFIG_MMC_BCM2835=y in bcm2835

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87inorp4nd.fsf@eliezer.anholt.net>
Date:   Fri, 03 Feb 2017 09:26:14 -0800
From:   Eric Anholt <eric@...olt.net>
To:     Gerd Hoffmann <kraxel@...hat.com>,
        linux-rpi-kernel@...ts.infradead.org
Cc:     ulf.hansson@...aro.org, robh+dt@...nel.org, mark.rutland@....com,
        f.fainelli@...il.com, rjui@...adcom.com, sbranden@...adcom.com,
        bcm-kernel-feedback-list@...adcom.com, swarren@...dotorg.org,
        lee@...nel.org, linux@...linux.org.uk, catalin.marinas@....com,
        will.deacon@....com, linux-mmc@...r.kernel.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, Gerd Hoffmann <kraxel@...hat.com>
Subject: Re: [PATCH v2 4/8] arm: set CONFIG_MMC_BCM2835=y in bcm2835_defconfig

Gerd Hoffmann <kraxel@...hat.com> writes:

> ---
>  arch/arm/configs/bcm2835_defconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/configs/bcm2835_defconfig b/arch/arm/configs/bcm2835_defconfig
> index 4b89f4e..3767c24 100644
> --- a/arch/arm/configs/bcm2835_defconfig
> +++ b/arch/arm/configs/bcm2835_defconfig
> @@ -92,6 +92,7 @@ CONFIG_MMC=y
>  CONFIG_MMC_SDHCI=y
>  CONFIG_MMC_SDHCI_PLTFM=y
>  CONFIG_MMC_SDHCI_IPROC=y
> +CONFIG_MMC_BCM2835=y
>  CONFIG_NEW_LEDS=y
>  CONFIG_LEDS_CLASS=y
>  CONFIG_LEDS_GPIO=y

If you end up resubmitting this, could you extend the commit message of
the defconfig changes to explain why it's being done?  Something like:

"We need to enable this controller so that we can switch the SD card's
pinmux over to it by default, which will improve storage read/write
speed."

(even better if we have some sort of stats on how much better it is).

Download attachment "signature.asc" of type "application/pgp-signature" (833 bytes)