linux-kernel - Re: [PATCH 3/6] staging: bcm2835-v4l2: Add a build system for the module.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170203170126.0881e5b3@vento.lan>
Date:   Fri, 3 Feb 2017 17:01:26 -0200
From:   Mauro Carvalho Chehab <mchehab@...pensource.com>
To:     Eric Anholt <eric@...olt.net>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        devel@...verdev.osuosl.org, linux-media@...r.kernel.org,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-rpi-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/6] staging: bcm2835-v4l2: Add a build system for the
 module.

Em Fri, 27 Jan 2017 13:55:00 -0800
Eric Anholt <eric@...olt.net> escreveu:

> This is derived from the downstream tree's build system, but with just
> a single Kconfig option.
> 
> For now the driver only builds on 32-bit arm -- the aarch64 build
> breaks due to the driver using arm-specific cache flushing functions.
> 
> Signed-off-by: Eric Anholt <eric@...olt.net>
> ---
>  drivers/staging/media/Kconfig                   |  2 ++
>  drivers/staging/media/Makefile                  |  1 +
>  drivers/staging/media/platform/bcm2835/Kconfig  | 10 ++++++++++
>  drivers/staging/media/platform/bcm2835/Makefile | 11 +++++++++++
>  4 files changed, 24 insertions(+)
>  create mode 100644 drivers/staging/media/platform/bcm2835/Kconfig
>  create mode 100644 drivers/staging/media/platform/bcm2835/Makefile
> 
> diff --git a/drivers/staging/media/Kconfig b/drivers/staging/media/Kconfig
> index ffb8fa72c3da..abd0e2d57c20 100644
> --- a/drivers/staging/media/Kconfig
> +++ b/drivers/staging/media/Kconfig
> @@ -27,6 +27,8 @@ source "drivers/staging/media/davinci_vpfe/Kconfig"
>  
>  source "drivers/staging/media/omap4iss/Kconfig"
>  
> +source "drivers/staging/media/platform/bcm2835/Kconfig"
> +
>  source "drivers/staging/media/s5p-cec/Kconfig"
>  
>  # Keep LIRC at the end, as it has sub-menus
> diff --git a/drivers/staging/media/Makefile b/drivers/staging/media/Makefile
> index a28e82cf6447..dc89325c463d 100644
> --- a/drivers/staging/media/Makefile
> +++ b/drivers/staging/media/Makefile
> @@ -2,6 +2,7 @@ obj-$(CONFIG_I2C_BCM2048)	+= bcm2048/
>  obj-$(CONFIG_VIDEO_SAMSUNG_S5P_CEC) += s5p-cec/
>  obj-$(CONFIG_DVB_CXD2099)	+= cxd2099/
>  obj-$(CONFIG_LIRC_STAGING)	+= lirc/
> +obj-$(CONFIG_VIDEO_BCM2835)	+= platform/bcm2835/
>  obj-$(CONFIG_VIDEO_DM365_VPFE)	+= davinci_vpfe/
>  obj-$(CONFIG_VIDEO_OMAP4)	+= omap4iss/
>  obj-$(CONFIG_VIDEO_STI_HDMI_CEC) += st-cec/
> diff --git a/drivers/staging/media/platform/bcm2835/Kconfig b/drivers/staging/media/platform/bcm2835/Kconfig
> new file mode 100644
> index 000000000000..7c5245dc3225
> --- /dev/null
> +++ b/drivers/staging/media/platform/bcm2835/Kconfig
> @@ -0,0 +1,10 @@
> +config VIDEO_BCM2835
> +	tristate "Broadcom BCM2835 camera driver"
> +	depends on VIDEO_V4L2 && (ARCH_BCM2835 || COMPILE_TEST)
> +	depends on BCM2835_VCHIQ
> +	depends on ARM
> +	select VIDEOBUF2_VMALLOC
> +	help
> +	  Say Y here to enable camera host interface devices for
> +	  Broadcom BCM2835 SoC. This operates over the VCHIQ interface
> +	  to a service running on VideoCore.
> diff --git a/drivers/staging/media/platform/bcm2835/Makefile b/drivers/staging/media/platform/bcm2835/Makefile
> new file mode 100644
> index 000000000000..d7900a5951a8
> --- /dev/null
> +++ b/drivers/staging/media/platform/bcm2835/Makefile
> @@ -0,0 +1,11 @@
> +bcm2835-v4l2-$(CONFIG_VIDEO_BCM2835) := \
> +	bcm2835-camera.o \
> +	controls.o \
> +	mmal-vchiq.o
> +
> +obj-$(CONFIG_VIDEO_BCM2835) += bcm2835-v4l2.o
> +
> +ccflags-y += \
> +	-Idrivers/staging/vc04_services \
> +	-Idrivers/staging/vc04_services/interface/vcos/linuxkernel \
> +	-D__VCCOREVER__=0x04000000

Huh! specifying the version of the videocore by a define seems
wrong! This is the type of thing that should be provided via DT.





Thanks,
Mauro