linux-kernel - Re: [PATCH] Fixed coding style issues of xmit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170203211214.GA18478@kroah.com>
Date:   Fri, 3 Feb 2017 22:12:14 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Abhijit Naik <abhijitnaik27@...il.com>
Cc:     Larry.Finger@...inger.net, florian.c.schilhabel@...glemail.com,
        bhaktipriya96@...il.com, daniel.baluta@...el.com,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Fixed coding style issues of xmit_linux.c

On Fri, Feb 03, 2017 at 07:49:26PM +0530, Abhijit Naik wrote:
> This patch will increase readability of xmit_linux.c file.
> 
> Removed following type of coding style warnings generated for xmit_linux.c,
> 	1. Braces {} are not necessary for single statement blocks
> 	2. Block comments use a trailing */ on a separate line

When you have to list the different things you do in a kernel patch,
that's a huge flag that you need to break this up into multiple patches.

Please do that here.

Also, please fix up your subject to be better suited to this subsystem
and driver, look at the other patches that have been made to this part
of the kernel to get an idea of what you need to do.

thanks,

greg k-h