linux-kernel - Re: [PATCH v2 2/2] net: ethernet: bgmac: mac address change bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <43694eda-e7fd-0df5-6bec-147770e04d5c@milecki.pl>
Date:   Fri, 3 Feb 2017 22:44:50 +0100
From:   Rafał Miłecki <rafal@...ecki.pl>
To:     Jon Mason <jon.mason@...adcom.com>,
        David Miller <davem@...emloft.net>
Cc:     bcm-kernel-feedback-list@...adcom.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, Hari Vyas <hariv@...adcom.com>
Subject: Re: [PATCH v2 2/2] net: ethernet: bgmac: mac address change bug

On 02/03/2017 10:08 PM, Jon Mason wrote:
> From: Hari Vyas <hariv@...adcom.com>
>
> ndo_set_mac_address() passes struct sockaddr * as 2nd parameter to
> bgmac_set_mac_address() but code assumed u8 *.  This caused two bytes
> chopping and the wrong mac address was configured.
>
> Signed-off-by: Hari Vyas <hariv@...adcom.com>
> Signed-off-by: Jon Mason <jon.mason@...adcom.com>
> Fixes: 4e209001b86 ("bgmac: write mac address to hardware in ndo_set_mac_address")

I think you were going to Cc stable?