linux-kernel - Re: modversions: redefine kcrctab entries as 32-bit values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170203050954.4qisyy66es6yjhkg@jeyu>
Date:   Thu, 2 Feb 2017 21:09:54 -0800
From:   Jessica Yu <jeyu@...hat.com>
To:     Ard Biesheuvel <ard.biesheuvel@...aro.org>
Cc:     linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        akpm@...ux-foundation.org, torvalds@...ux-foundation.org,
        arnd@...db.de, rusty@...tcorp.com.au, mpe@...erman.id.au,
        viro@...iv.linux.org.uk, linux-arm-kernel@...ts.infradead.org,
        linux@...linux.org.uk, linux-arch@...r.kernel.org
Subject: Re: modversions: redefine kcrctab entries as 32-bit values

+++ Jessica Yu [02/02/17 22:54 -0500]:
>+++ Ard Biesheuvel [24/01/17 16:16 +0000]:
>>This v4 is a followup to [0] 'modversions: redefine kcrctab entries as
>>relative CRC pointers', but since relative CRC pointers do not work in
>>modules, and are actually only needed by powerpc with CONFIG_RELOCATABLE=y,
>>I have made it a Kconfig selectable feature instead.
>>
>>Patch #1 introduces the MODULE_REL_CRCS Kconfig symbol, and adds the kbuild
>>handling of it, i.e., modpost, genksyms and kallsyms.
>>
>>Patch #2 switches all architectures to 32-bit CRC entries in kcrctab, where
>>all architectures except powerpc with CONFIG_RELOCATABLE=y use absolute ELF
>>symbol references as before.
>>
>>v4: make relative CRCs kconfig selectable
>>   use absolute CRC symbols in modules regardless of kconfig selection
>>   split into two patches
>
>This asymmetry threw me off a bit, especially the Kconfig naming (only
>vmlinux crcs get the relative offsets, and only on powerpc atm, but all
>modules keep the absolute syms, but it is called MODULE_REL_CRCS...),
>if we keep this asymmetric crc treatment, it would be really nice to
>note this discrepancy this somewhere, perhaps in the Kconfig, to keep
>our heads from spinning :-)
>
>I'm still catching up on the previous discussion threads, but can you
>explain a bit more why you switched away from full blown relative crcs
>from your last patchset [1]? I had lightly tested your v3 on ppc64le
>previously, and relative offsets with modules seemed to worked very
>well. I'm probably missing something very obvious.

Ah, I just saw your other comment about other arches not having support
for the rel32 offsets :-/

The asymmetry still bothers me though. Can't we have something that just
switches relative crcs on and off, that applies to *both* vmlinux and modules?
Then we can get rid of the crc_owner check in check_version() and just have
something like:

   if (IS_ENABLED(CONFIG_RELATIVE_CRCS))
       crcval = resolve_crc(crc);

Also we could get rid of the '&& !defined(MODULE)' checks scattered in
export.h. Then the arches that want relative crcs and that *do* have rel32
relocation support can turn relative crcs on, and powerpc can enable it, right?

Would that work or is there another reason this won't work with modules
(assuming that the arches that select this option support the relative
offsets)?

Jessica