linux-kernel - Re: [PATCH 2/5] regulator: core: have regulator_dev_lookup() return ERR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170204101159.yzpbbnjp3oxoc362@sirena.org.uk>
Date:   Sat, 4 Feb 2017 11:11:59 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     Liam Girdwood <lgirdwood@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/5] regulator: core: have regulator_dev_lookup() return
 ERR_PTR-encoded errors

On Fri, Feb 03, 2017 at 01:56:01PM -0800, Dmitry Torokhov wrote:

> -	return NULL;
> +	return r ? r : ERR_PTR(-ENODEV);
>  }

Please write normal conditional statements to keep the code legible.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)