linux-kernel - Re: [PATCH] asus-wireless: Fix identation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 4 Feb 2017 17:10:55 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     João Paulo Rechi Vita <jprvita@...il.com>
Cc:     Darren Hart <dvhart@...radead.org>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        acpi4asus-user <acpi4asus-user@...ts.sourceforge.net>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        linux@...lessm.com,
        João Paulo Rechi Vita <jprvita@...lessm.com>
Subject: Re: [PATCH] asus-wireless: Fix identation

On Sat, Feb 4, 2017 at 5:08 PM, Andy Shevchenko
<andy.shevchenko@...il.com> wrote:
> On Wed, Feb 1, 2017 at 2:27 PM, João Paulo Rechi Vita <jprvita@...il.com> wrote:
>
> Do not leave empty commit message. Describe your changes here in a few words.
>
> For the drivers/platform/x86 use a pattern in subject
>
> platform/x86: asus-wireless: ...

And one more, use versioning of your patches: PATCHv1, PATCHv2, ...

>
>> Signed-off-by: João Paulo Rechi Vita <jprvita@...lessm.com>
>> ---
>>  drivers/platform/x86/asus-wireless.c | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/platform/x86/asus-wireless.c b/drivers/platform/x86/asus-wireless.c
>> index 9f31bc1a47d0..a7ee18383146 100644
>> --- a/drivers/platform/x86/asus-wireless.c
>> +++ b/drivers/platform/x86/asus-wireless.c
>> @@ -76,8 +76,7 @@ static void led_state_update(struct work_struct *work)
>>                              data->led_state);
>>  }
>>
>> -static void led_state_set(struct led_classdev *led,
>> -                                 enum led_brightness value)
>> +static void led_state_set(struct led_classdev *led, enum led_brightness value)
>>  {
>>         struct asus_wireless_data *data;
>>
>> --
>> 2.11.0
>>
>
>
>
> --
> With Best Regards,
> Andy Shevchenko



-- 
With Best Regards,
Andy Shevchenko