linux-kernel - Re: [PATCH] xen-netfront: Improve error handling during initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170204.194714.2295825542000326986.davem@davemloft.net>
Date:   Sat, 04 Feb 2017 19:47:14 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     ross.lagerwall@...rix.com
Cc:     xen-devel@...ts.xenproject.org, netdev@...r.kernel.org,
        boris.ostrovsky@...cle.com, jgross@...e.com,
        linux-kernel@...r.kernel.org, wei.liu2@...rix.com
Subject: Re: [PATCH] xen-netfront: Improve error handling during
 initialization

From: Ross Lagerwall <ross.lagerwall@...rix.com>
Date: Wed, 1 Feb 2017 15:50:22 +0000

> * Delay timer creation so that if initializing a queue fails, the timer
> has not been setup yet.

setup_timer() doesn't do anything that must be "undone" if an error
occurs and we have to cleanup.

It just assigns some values to some timer struct fields, that's it.

Therefore this change is extraneous and unnecessary.