linux-kernel - Re: [PATCH] iio: adc: handle unknow of_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1ab64563-e536-ab8a-5d1e-f77cbf519dda@kernel.org>
Date:   Sun, 5 Feb 2017 09:32:02 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Marek Vasut <marek.vasut@...il.com>, Arnd Bergmann <arnd@...db.de>
Cc:     Marek Vasut <marek.vasut+renesas@...il.com>,
        Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        linux-iio@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] iio: adc: handle unknow of_device_id data

On 04/02/17 21:47, Marek Vasut wrote:
> On 02/04/2017 10:44 PM, Arnd Bergmann wrote:
>> On Sat, Feb 4, 2017 at 10:11 PM, Marek Vasut <marek.vasut@...il.com> wrote:
>>> On 02/03/2017 06:01 PM, Arnd Bergmann wrote:
>>>> diff --git a/drivers/iio/adc/rcar-gyroadc.c b/drivers/iio/adc/rcar-gyroadc.c
>>>> index 0c44f72c32a8..331ff9a673be 100644
>>>> --- a/drivers/iio/adc/rcar-gyroadc.c
>>>> +++ b/drivers/iio/adc/rcar-gyroadc.c
>>>> @@ -336,7 +336,7 @@ static int rcar_gyroadc_parse_subdevs(struct iio_dev *indio_dev)
>>>>       struct device_node *child;
>>>>       struct regulator *vref;
>>>>       unsigned int reg;
>>>> -     unsigned int adcmode, childmode;
>>>> +     unsigned int adcmode = -1, childmode;
>>>>       unsigned int sample_width;
>>>>       unsigned int num_channels;
>>>>       int ret, first = 1;
>>>> @@ -366,6 +366,9 @@ static int rcar_gyroadc_parse_subdevs(struct iio_dev *indio_dev)
>>>>                       channels = rcar_gyroadc_iio_channels_3;
>>>>                       num_channels = ARRAY_SIZE(rcar_gyroadc_iio_channels_3);
>>>>                       break;
>>>> +             default:
>>>> +                     dev_err(dev, "unknown device type");
>>>
>>> Is this verbose output really needed ?
>>
>> I don't care much either way, I was just trying to follow what the function does
>> for the other failure cases. We can probably drop it though, as this
>> would indicate
>> a bug in the driver implementation, while the others are about
>> incorrect DT data.
> 
> I don't really want to pester you too much with minor details, let's
> wait for JIC's opinion. If you're resending, please add my Ack,
> otherwise consider this patch:
> 
> Acked-by: Marek Vasut <marek.vasut@...il.com>
> 
I've applied with the dev_err dropped.  Didn't care that much either
way :)

Anyhow, applied to the fixes-togreg-post-rc1 branch of iio.git as
I might not get another pull request out pre the merge window.
(if I do I'll apply it with that).

Thanks,

Jonathan