lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CACRpkdb=U+UMRqR2GKGwDzk9X_nLv0tf2dZ8LhDGceAD83LKag@mail.gmail.com>
Date:   Mon, 6 Feb 2017 09:46:53 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Alexandre Torgue <alexandre.torgue@...com>
Cc:     Rob Herring <robh@...nel.org>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Mark Rutland <mark.rutland@....com>,
        Arnd Bergmann <arnd@...db.de>,
        Russell King <linux@...linux.org.uk>,
        Olof Johansson <olof@...om.net>,
        Patrice Chotard <patrice.chotard@...com>,
        Lee Jones <lee.jones@...aro.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 6/8] Documentation: dt: Add new compatible to STM32
 pinctrl driver bindings

On Wed, Feb 1, 2017 at 4:58 PM, Alexandre Torgue
<alexandre.torgue@...com> wrote:
> On 02/01/2017 04:06 PM, Rob Herring wrote:
>>
>> On Fri, Jan 27, 2017 at 05:15:19PM +0100, Alexandre TORGUE wrote:
>>>
>>> Add new compatible for stm32f469 MCU.
>>>
>>> Signed-off-by: Alexandre TORGUE <alexandre.torgue@...com>
>>>
>>> diff --git
>>> a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt
>>> b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt
>>> index 25d9809..4f0487d 100644
>>> --- a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt
>>> +++ b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt
>>> @@ -9,7 +9,8 @@ Pin controller node:
>>>  Required properies:
>>>   - compatible: value should be one of the following:
>>>     (a) "st,stm32f429-pinctrl"
>>> -   (b) "st,stm32f746-pinctrl"
>>> +   (b) "st,stm32f469-pinctrl"
>>> +   (c) "st,stm32f746-pinctrl"
>>
>>
>> Drop the a,b,c. Otherwise, you'll be changing a bunch of lines every
>> time.
>
>
> I completely agree.
>
> Linus, Do i need to send a v2 for this patch ?

Nopes, applied the amended v1 patch already with these
changes, check the result.

Yours,
Linus Walleij

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ