linux-kernel - Re: [PATCH] tracing/kprobes: fix _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 6 Feb 2017 11:26:53 +0900
From:   Masami Hiramatsu <mhiramat@...nel.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Steven Rostedt <rostedt@...dmis.org>,
        Ingo Molnar <mingo@...hat.com>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Marcin Nowakowski <marcin.nowakowski@...tec.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tracing/kprobes: fix __init annotation

On Wed,  1 Feb 2017 17:57:56 +0100
Arnd Bergmann <arnd@...db.de> wrote:

> clang complains about "__init" being attached to a struct name:
> 
> kernel/trace/trace_kprobe.c:1375:15: error: '__section__' attribute only applies to functions and global variables
> 
> The intention must have been to mark the function as __init instead of
> the type, so move the attribute there.
> 
> Fixes: f18f97ac43d7 ("tracing/kprobes: Add a helper method to return number of probe hits")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Looks good to me.

Acked-by: Masami Hiramatsu <mhiramat@...nel.org>

Thanks!

> ---
>  kernel/trace/trace_kprobe.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c
> index a133ecd741e4..7ad9e53ad174 100644
> --- a/kernel/trace/trace_kprobe.c
> +++ b/kernel/trace/trace_kprobe.c
> @@ -1372,7 +1372,7 @@ kprobe_trace_selftest_target(int a1, int a2, int a3, int a4, int a5, int a6)
>  	return a1 + a2 + a3 + a4 + a5 + a6;
>  }
>  
> -static struct __init trace_event_file *
> +static __init struct trace_event_file *
>  find_trace_probe_file(struct trace_kprobe *tk, struct trace_array *tr)
>  {
>  	struct trace_event_file *file;
> -- 
> 2.9.0
> 


-- 
Masami Hiramatsu <mhiramat@...nel.org>