linux-kernel - Re: [PATCH -next] drm: mxsfb: Make local symbol mxsfb_funcs static

Open Source and information security mailing list archives

Message-ID: <20170206100206.vhxwbfhhgzm2m32h@phenom.ffwll.local>
Date:   Mon, 6 Feb 2017 11:02:06 +0100
From:   Daniel Vetter <daniel@...ll.ch>
To:     Wei Yongjun <weiyj.lk@...il.com>
Cc:     Marek Vasut <marex@...x.de>, David Airlie <airlied@...ux.ie>,
        Wei Yongjun <weiyongjun1@...wei.com>,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH -next] drm: mxsfb: Make local symbol mxsfb_funcs static

On Sun, Feb 05, 2017 at 04:05:38PM +0000, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@...wei.com>
> 
> Fixes the following sparse warning:
> 
> drivers/gpu/drm/mxsfb/mxsfb_drv.c:129:38: warning:
>  symbol 'mxsfb_funcs' was not declared. Should it be static?
> 
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>

Both of your patches applied to drm-misc-next for 4.12.

Thanks, Daniel

> ---
>  drivers/gpu/drm/mxsfb/mxsfb_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> index cdfbe02..ff0495d 100644
> --- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> +++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> @@ -126,7 +126,7 @@ static int mxsfb_pipe_prepare_fb(struct drm_simple_display_pipe *pipe,
>  	return drm_fb_cma_prepare_fb(&pipe->plane, plane_state);
>  }
>  
> -struct drm_simple_display_pipe_funcs mxsfb_funcs = {
> +static struct drm_simple_display_pipe_funcs mxsfb_funcs = {
>  	.enable		= mxsfb_pipe_enable,
>  	.disable	= mxsfb_pipe_disable,
>  	.update		= mxsfb_pipe_update,
> 
> 
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives