linux-kernel - Re: [PATCH] gpio: dwapb: Add support for next generation of X-Gene SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdZw-QLOeiPqSRaEJ+mGGDwi5fh9B1uenPxQGBtTwj+cuw@mail.gmail.com>
Date:   Mon, 6 Feb 2017 11:21:09 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Hoan Tran <hotran@....com>, Jamie Iles <jamie@...ieiles.com>,
        Weike Chen <alvin.chen@...el.com>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Cc:     Alexandre Courbot <gnurou@...il.com>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Loc Ho <lho@....com>, Duc Dang <dhdang@....com>
Subject: Re: [PATCH] gpio: dwapb: Add support for next generation of X-Gene SoC

On Tue, Jan 31, 2017 at 8:43 PM, Hoan Tran <hotran@....com> wrote:

> Next generation of X-Gene SoC's GPIO hardware register map is very
> similar to DW GPIO. It only differs by a few register addresses.
> This patch modifies DW GPIO driver to accommodate the difference
> in a few register addresses.
>
> Signed-off-by: Hoan Tran <hotran@....com>

On next iteration please include Jamie Iles, Weike Chen and Sebastian
Andrzej Siewior.
They all provided substantial contributions to this driver.

The dwapb needs a proper maintainer in MAINTAINERS actually, it is one of
those that can't use GPIOLIB_IRQCHIP so it requires special attention.
Jamie, interested in the job? Patches welcome :)

Also I've been thinking about this:

#define GPIO_SWPORTA_DR         0x00
#define GPIO_SWPORTA_DDR        0x04
#define GPIO_SWPORTB_DR         0x0c
#define GPIO_SWPORTB_DDR        0x10
#define GPIO_SWPORTC_DR         0x18
#define GPIO_SWPORTC_DDR        0x1c
#define GPIO_SWPORTD_DR         0x24
#define GPIO_SWPORTD_DDR        0x28
#define GPIO_INTEN              0x30
#define GPIO_INTMASK            0x34
#define GPIO_INTTYPE_LEVEL      0x38
#define GPIO_INT_POLARITY       0x3c
#define GPIO_INTSTATUS          0x40
#define GPIO_PORTA_DEBOUNCE     0x48
#define GPIO_PORTA_EOI          0x4c
#define GPIO_EXT_PORTA          0x50
#define GPIO_EXT_PORTB          0x54
#define GPIO_EXT_PORTC          0x58
#define GPIO_EXT_PORTD          0x5c

I wonder what is at addresses 0x08, 0x14, 0x20, 0x2c, 0x44?

Anything interesting we should know about? I bet they are not just
dead address space.

Is there a public datasheet for this thing that I can look at?

Yours,
Linus Walleij