linux-kernel - Re: [PATCH v2 1/7] gpio: mockup: readability tweaks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 6 Feb 2017 14:20:51 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Bartosz Golaszewski <bgolaszewski@...libre.com>
Cc:     Alexandre Courbot <gnurou@...il.com>,
        Bamvor Jian Zhang <bamvor.zhangjian@...aro.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/7] gpio: mockup: readability tweaks

On Mon, Feb 6, 2017 at 1:10 PM, Bartosz Golaszewski
<bgolaszewski@...libre.com> wrote:

> The following patch tries to improve the readability of the mockup
> driver.
>
> The driver is called gpio-mockup, so add the same prefix to all
> functions and structures.
>
> Add some newlines and use a temporary pointer in gpio_mockup_add().
>
> Drop the name of the direction enum and rename the enum values to
> better reflect their purpose.
>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@...libre.com>

Patch applied.

Yours,
Linus Walleij