linux-kernel - Re: [PATCH] CIFS: use correct format string for size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1486389455.2576.14.camel@redhat.com>
Date:   Mon, 06 Feb 2017 19:27:35 +0530
From:   Sachin Prabhu <sprabhu@...hat.com>
To:     Arnd Bergmann <arnd@...db.de>, Steve French <sfrench@...ba.org>
Cc:     Pavel Shilovsky <pshilov@...rosoft.com>,
        Aurelien Aptel <aaptel@...e.com>, linux-cifs@...r.kernel.org,
        samba-technical@...ts.samba.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] CIFS: use correct format string for size_t

On Thu, 2017-02-02 at 13:21 +0100, Arnd Bergmann wrote:
> This warning is harmless as size_t is always as wide as 'unsigned
> long':
> 
> fs/cifs/smb2ops.c:2008:245: error: format '%lu' expects argument of
> type 'long unsigned int', but argument 5 has type 'size_t {aka
> unsigned int}' [-Werror=format=]
> 
> Using %zu however is the correct format string that we don't get a
> warning for.
> 
> Fixes: c9d651a5a2fe ("CIFS: Decrypt and process small encrypted
> packets")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Acked-by: Sachin Prabhu <sprabhu@...hat.com>

> ---
>  fs/cifs/smb2ops.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/cifs/smb2ops.c b/fs/cifs/smb2ops.c
> index 0764c32754b0..ac6e10adf000 100644
> --- a/fs/cifs/smb2ops.c
> +++ b/fs/cifs/smb2ops.c
> @@ -2005,7 +2005,7 @@ handle_read_data(struct TCP_Server_Info
> *server, struct mid_q_entry *mid,
>  	rdata->iov[0].iov_len = 4;
>  	rdata->iov[1].iov_base = buf + 4;
>  	rdata->iov[1].iov_len = server->vals->read_rsp_size - 4;
> -	cifs_dbg(FYI, "0: iov_base=%p iov_len=%lu\n",
> +	cifs_dbg(FYI, "0: iov_base=%p iov_len=%zu\n",
>  		 rdata->iov[0].iov_base, server->vals-
> >read_rsp_size);
>  
>  	length = rdata->copy_into_pages(server, rdata, &iter);