linux-kernel - Re: [PATCH 4/4] md: fast clone bio in bio_clone

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170206142451.GA17008@infradead.org>
Date:   Mon, 6 Feb 2017 06:24:51 -0800
From:   Christoph Hellwig <hch@...radead.org>
To:     Ming Lei <tom.leiming@...il.com>
Cc:     Christoph Hellwig <hch@...radead.org>,
        Shaohua Li <shli@...nel.org>, Jens Axboe <axboe@...com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "open list:SOFTWARE RAID (Multiple Disks) SUPPORT" 
        <linux-raid@...r.kernel.org>,
        linux-block <linux-block@...r.kernel.org>,
        NeilBrown <neilb@...e.com>
Subject: Re: [PATCH 4/4] md: fast clone bio in bio_clone_mddev()

On Mon, Feb 06, 2017 at 06:43:32PM +0800, Ming Lei wrote:
> In theory, ->bio_set still might be NULL in case of failed memory allocation,
> please see md_run().

And that's something that should be fixed.  Silently not having mempool
is very bad behavior.