linux-kernel - Re: [PATCH v3] staging: lustre: align else if statement to coding standard

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1486392629.3616.4.camel@perches.com>
Date:   Mon, 06 Feb 2017 06:50:29 -0800
From:   Joe Perches <joe@...ches.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Maksymilian Piechota <maksymilianpiechota@...il.com>
Cc:     linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org
Subject: Re: [PATCH v3] staging: lustre: align else if statement to coding
 standard

On Mon, 2017-02-06 at 14:03 +0100, Greg Kroah-Hartman wrote:
> On Mon, Feb 06, 2017 at 07:56:39AM -0500, Maksymilian Piechota wrote:
> > On Mon, Feb 06, 2017 at 01:50:02PM +0100, Greg Kroah-Hartman wrote:
> > > On Mon, Feb 06, 2017 at 07:26:56AM -0500, Maksymilian Piechota wrote:
> > > > - move logical continuations at the end of line
> > > > - move else if statement to a single line
> > > > - Replace spaces with tabstop.
> > > 
> > > That's a lot of different things, happening all at once.  Please break
> > > this up into multiple patches, each one only doing one thing, and send a
> > > patch series.
> > > 
> > > thanks,
> > > 
> > > greg k-h
> > 
> > Fixing two lines of code in three patches?
> 
> Yes.

Greg is also sometimes completely crazy.

I think he's only doing this because you are a
relatively new patch submitter and he wants you
to go through some linux-kernel process hazing.

It'd be more efficient as a single patch and better
overall to avoid descriptions with multiple
characteristics that elicit Greg's somewhat OCD
reflexes.

If this commit log was merely described as "use a
normal kernel style" for the else if and nothing
else was mentioned, this would likely have been
accepted.