lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 6 Feb 2017 07:02:24 -0800 From: Matthew Wilcox <willy@...radead.org> To: Zi Yan <zi.yan@...t.com> Cc: linux-kernel@...r.kernel.org, linux-mm@...ck.org, kirill.shutemov@...ux.intel.com, akpm@...ux-foundation.org, minchan@...nel.org, vbabka@...e.cz, mgorman@...hsingularity.net, n-horiguchi@...jp.nec.com, khandual@...ux.vnet.ibm.com, zi.yan@...rutgers.edu, Zi Yan <ziy@...dia.com> Subject: Re: [PATCH v3 01/14] mm: thp: make __split_huge_pmd_locked visible. On Sun, Feb 05, 2017 at 11:12:39AM -0500, Zi Yan wrote: > +++ b/include/linux/huge_mm.h > @@ -120,6 +120,8 @@ static inline int split_huge_page(struct page *page) > } > void deferred_split_huge_page(struct page *page); > > +void __split_huge_pmd_locked(struct vm_area_struct *vma, pmd_t *pmd, > + unsigned long haddr, bool freeze); Could you change that from 'haddr' to 'address' so callers who only read the header instead of the implementation aren't expecting to align it themselves? > +void __split_huge_pmd_locked(struct vm_area_struct *vma, pmd_t *pmd, > + unsigned long address, bool freeze) > { > struct mm_struct *mm = vma->vm_mm; > struct page *page;
Powered by blists - more mailing lists