linux-kernel - Re: [PATCH v3 1/3] lib/string: introduce ascii2utf16le() helper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4730c4f2-6012-5267-90d3-bc447ec7963d@skidata.com>
Date:   Mon, 6 Feb 2017 16:31:01 +0100
From:   Richard Leitner <richard.leitner@...data.com>
To:     Alan Stern <stern@...land.harvard.edu>
CC:     <linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <gregkh@...uxfoundation.org>,
        <robh+dt@...nel.org>, <mark.rutland@....com>,
        <akpm@...ux-foundation.org>, <andriy.shevchenko@...ux.intel.com>,
        <keescook@...omium.org>, <dev@...l1n.net>
Subject: Re: [PATCH v3 1/3] lib/string: introduce ascii2utf16le() helper

On 02/06/2017 04:12 PM, Alan Stern wrote:
> On Mon, 6 Feb 2017, Richard Leitner wrote:
> 
>> For USB string descriptors we need to convert ASCII strings to UTF16-LE.
>> Therefore make a simple helper function (based on ascii2desc from
>> drivers/usb/core/hcd.c) for that purpose.
> 
> You know, we already have utf8s_to_utf16s() in fs/nls/nls_base.c.  
> Maybe it doesn't do exactly what you want, but it should be pretty 
> close.  Adding another helper function to do essentially the same thing 
> seems unnecessary.

Thanks for that pointer. I totally agree with you.

So it would be OK to include linux/nls.h and use utf8s_to_utf16s() in
drivers/usb/{core/hcd.c,misc/usb251xb.c}?

Thanks & regards,
Richard L