linux-kernel - Re: [PATCH net-next v1 7/7] bpf: Always test unprivileged programs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <58989FA0.7000906@fb.com>
Date:   Mon, 6 Feb 2017 08:09:04 -0800
From:   Alexei Starovoitov <ast@...com>
To:     Mickaël Salaün <mic@...ikod.net>,
        <linux-kernel@...r.kernel.org>
CC:     <netdev@...r.kernel.org>, Daniel Borkmann <daniel@...earbox.net>,
        "Shuah Khan" <shuah@...nel.org>,
        Arnaldo Carvalho de Melo <acme@...radead.org>
Subject: Re: [PATCH net-next v1 7/7] bpf: Always test unprivileged programs

On 2/5/17 3:14 PM, Mickaël Salaün wrote:
> -		if (unpriv && test->prog_type)
> -			continue;
> +		if (!test->prog_type) {
> +			if (!unpriv)
> +				set_admin(false);
> +			printf("#%d/u %s ", i, test->descr);
> +			do_test_single(test, true, &passes, &errors);
> +			if (!unpriv)
> +				set_admin(true);
> +		}
>
> -		printf("#%d %s ", i, test->descr);
> -		do_test_single(test, unpriv, &passes, &errors);
> +		if (!unpriv) {
> +			printf("#%d/p %s ", i, test->descr);
> +			do_test_single(test, false, &passes, &errors);
> +		}

great idea.
Acked-by: Alexei Starovoitov <ast@...nel.org>

as far as other patches.. we need to figure out how to avoid conflicts
between net-next and Arnaldo's tree where Joe's patches went.

Mickael,
can you see some way of splitting the patch set between trees?
Like above test_verfier.c improvement needs to go into net-next.
The rest can go via perf