linux-kernel - RE: [PATCH] [net-next] mlxsw: add psample dependency for spectrum

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DB3PR05MB07645B7262AF8259EA80D973AC400@DB3PR05MB0764.eurprd05.prod.outlook.com>
Date:   Mon, 6 Feb 2017 16:41:27 +0000
From:   Yotam Gigi <yotamg@...lanox.com>
To:     Arnd Bergmann <arnd@...db.de>, Jiri Pirko <jiri@...lanox.com>,
        "Ido Schimmel" <idosch@...lanox.com>
CC:     "David S. Miller" <davem@...emloft.net>,
        Vadim Pasternak <vadimp@...lanox.com>,
        Elad Raz <eladr@...lanox.com>, Ivan Vecera <cera@...a.cz>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] [net-next] mlxsw: add psample dependency for spectrum

>-----Original Message-----
>From: netdev-owner@...r.kernel.org [mailto:netdev-owner@...r.kernel.org] On
>Behalf Of Arnd Bergmann
>Sent: Monday, February 06, 2017 6:27 PM
>To: Jiri Pirko <jiri@...lanox.com>; Ido Schimmel <idosch@...lanox.com>
>Cc: Arnd Bergmann <arnd@...db.de>; David S. Miller <davem@...emloft.net>;
>Vadim Pasternak <vadimp@...lanox.com>; Elad Raz <eladr@...lanox.com>; Ivan
>Vecera <cera@...a.cz>; netdev@...r.kernel.org; linux-kernel@...r.kernel.org
>Subject: [PATCH] [net-next] mlxsw: add psample dependency for spectrum
>
>When PSAMPLE is a loadable module, spectrum must not be built-in:
>
>drivers/net/built-in.o: In function `mlxsw_sp_rx_listener_sample_func':
>spectrum.c:(.text+0xe357e): undefined reference to `psample_sample_packet'
>
>This adds a Kconfig dependency to enforce usable configurations.
>
>Fixes: 98d0f7b9acda ("mlxsw: spectrum: Add packet sample offloading support")
>Signed-off-by: Arnd Bergmann <arnd@...db.de>

Acked-by: Yotam Gigi <yotamg@...lanox.com>

>---
> drivers/net/ethernet/mellanox/mlxsw/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/drivers/net/ethernet/mellanox/mlxsw/Kconfig
>b/drivers/net/ethernet/mellanox/mlxsw/Kconfig
>index 76a7574c3c7d..ef23eaedc2ff 100644
>--- a/drivers/net/ethernet/mellanox/mlxsw/Kconfig
>+++ b/drivers/net/ethernet/mellanox/mlxsw/Kconfig
>@@ -73,6 +73,7 @@ config MLXSW_SWITCHX2
> config MLXSW_SPECTRUM
> 	tristate "Mellanox Technologies Spectrum support"
> 	depends on MLXSW_CORE && MLXSW_PCI && NET_SWITCHDEV &&
>VLAN_8021Q
>+	depends on PSAMPLE || PSAMPLE=n
> 	select PARMAN
> 	default m
> 	---help---
>--
>2.9.0