linux-kernel - Re: [PATCH 1/2] spi: davinci: Use SPI framework to handle DMA mapping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170206164825.7daqoxyv4zmbafyn@sirena.org.uk>
Date:   Mon, 6 Feb 2017 16:48:25 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Fabien Parent <fparent@...libre.com>
Cc:     linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org,
        nsekhar@...com, ptitiano@...libre.com, khilman@...libre.com
Subject: Re: [PATCH 1/2] spi: davinci: Use SPI framework to handle DMA mapping

On Mon, Feb 06, 2017 at 03:57:07PM +0100, Fabien Parent wrote:

> This commit updates the davinci SPI driver in order to use the SPI
> framework to handle the DMA mapping of buffers coming from an upper
> layer.

This claims to be using the framework to do DMA mapping but...

> +		if (!t->rx_buf) {
> +			sg_init_table(&sg_rx, 1);
> +			t->rx_dma = dma_map_single(&spi->dev, dummy_buf,
> +					t->len, DMA_FROM_DEVICE);
> +			if (dma_mapping_error(&spi->dev, !t->rx_dma)) {
> +				ret = -EFAULT;
> +				goto err_rx_map;
> +			}
> +			sg_dma_address(&sg_rx) = t->rx_dma;
> +			sg_dma_len(&sg_rx) = t->len;

...adds code that does DMA mapping.  That's confusing?

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)