lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 06 Feb 2017 09:55:12 -0800 From: Joe Perches <joe@...ches.com> To: Maksymilian Piechota <maksymilianpiechota@...il.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org> Cc: maksymilian.piechota@...il.com, linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org Subject: Re: [PATCH v4 2/2] staging: lustre: move else if statement to a single line On Mon, 2017-02-06 at 11:13 -0500, Maksymilian Piechota wrote: > diff --git a/drivers/staging/wlan-ng/prism2mgmt.c b/drivers/staging/wlan-ng/prism2mgmt.c [] > @@ -1307,8 +1307,7 @@ int prism2mgmt_wlansniff(struct wlandevice *wlandev, void *msgp) > && (msg->prismheader.data == P80211ENUM_truth_true)) { > hw->sniffhdr = 0; > wlandev->netdev->type = ARPHRD_IEEE80211_PRISM; > - } else > - if ((msg->wlanheader.status == P80211ENUM_msgitem_status_data_ok) && > + } else if ((msg->wlanheader.status == P80211ENUM_msgitem_status_data_ok) && > (msg->wlanheader.data == P80211ENUM_truth_true)) { > hw->sniffhdr = 1; > wlandev->netdev->type = ARPHRD_IEEE80211_PRISM; Hi again. When you change the else if on multiple lines to a single line, you should also realign the continuation like: } else if ((msg->wlanheader.status == P80211ENUM_msgitem_status_data_ok) && (msg->wlanheader.data == P80211ENUM_truth_true)) { Using 3 tabs then 3 spaces
Powered by blists - more mailing lists