linux-kernel - Re: [PATCH 2/3] pinctrl: spear: make bool drivers explicitly non-modular

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170207041249.GL3131@vireshk-i7>
Date:   Tue, 7 Feb 2017 09:42:49 +0530
From:   Viresh Kumar <viresh.kumar@...aro.org>
To:     Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:     linux-kernel@...r.kernel.org, Viresh Kumar <vireshk@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        spear-devel@...t.st.com, linux-gpio@...r.kernel.org
Subject: Re: [PATCH 2/3] pinctrl: spear: make bool drivers explicitly
 non-modular

On 06-02-17, 03:03, Paul Gortmaker wrote:
> None of the Kconfigs for any of these drivers are tristate,
> meaning that they currently are not being built as a module by anyone.
> 
> Lets remove the modular code that is essentially orphaned, so that
> when reading the drivers there is no doubt they are builtin-only.  All
> drivers get the exact same change, so they are handled in batch.
> 
> Changes are (1) use init.h header in place of module.h header,
> (2) delete module_exit related code, (3) delete MODULE_DEVICE_TABLE,
> and (4) delete MODULE_LICENCE/MODULE_AUTHOR and associated tags.
> 
> None of these drivers were using module_init() so we don't have to
> worry about the init ordering getting changed with this commit.
> 
> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
> 
> We also delete the MODULE_LICENSE etc. tags since all that information
> is already contained at the top of each file in the comments.
> 
> Cc: Viresh Kumar <vireshk@...nel.org>
> Cc: Linus Walleij <linus.walleij@...aro.org>
> Cc: spear-devel@...t.st.com
> Cc: linux-gpio@...r.kernel.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>
> ---
>  drivers/pinctrl/spear/pinctrl-plgpio.c    |  7 +------
>  drivers/pinctrl/spear/pinctrl-spear1310.c | 12 ------------
>  drivers/pinctrl/spear/pinctrl-spear1340.c | 12 ------------
>  drivers/pinctrl/spear/pinctrl-spear300.c  | 12 ------------
>  drivers/pinctrl/spear/pinctrl-spear310.c  | 12 ------------
>  drivers/pinctrl/spear/pinctrl-spear320.c  | 12 ------------
>  6 files changed, 1 insertion(+), 66 deletions(-)

Acked-by: Viresh Kumar <viresh.kumar@...aro.org>

-- 
viresh