linux-kernel - Re: [PATCH] remoteproc: Drop qcom_scm_pas_supported() from adsp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 6 Feb 2017 12:46:04 -0800
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     Sarangdhar Joshi <spjoshi@...eaurora.org>
Cc:     Ohad Ben-Cohen <ohad@...ery.com>,
        Andy Gross <andy.gross@...aro.org>,
        linux-remoteproc@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, Stephen Boyd <sboyd@...eaurora.org>,
        Trilok Soni <tsoni@...eaurora.org>
Subject: Re: [PATCH] remoteproc: Drop qcom_scm_pas_supported() from
 adsp_probe()

On Thu 02 Feb 16:04 PST 2017, Sarangdhar Joshi wrote:

> SCM call to check whether Peripheral Authentication Service (PAS)
> is supported returns false for ADSP. Drop this call from the driver
> so that the probe() function succeeds for ADSP PIL device.
> 

Applied, thanks

Regards,
Bjorn

> Signed-off-by: Sarangdhar Joshi <spjoshi@...eaurora.org>
> ---
>  drivers/remoteproc/qcom_adsp_pil.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/remoteproc/qcom_adsp_pil.c b/drivers/remoteproc/qcom_adsp_pil.c
> index 43a4ed2..94cd4b8 100644
> --- a/drivers/remoteproc/qcom_adsp_pil.c
> +++ b/drivers/remoteproc/qcom_adsp_pil.c
> @@ -318,11 +318,6 @@ static int adsp_probe(struct platform_device *pdev)
>  	if (!qcom_scm_is_available())
>  		return -EPROBE_DEFER;
>  
> -	if (!qcom_scm_pas_supported(ADSP_PAS_ID)) {
> -		dev_err(&pdev->dev, "PAS is not available for ADSP\n");
> -		return -ENXIO;
> -	}
> -
>  	rproc = rproc_alloc(&pdev->dev, pdev->name, &adsp_ops,
>  			    ADSP_FIRMWARE_NAME, sizeof(*adsp));
>  	if (!rproc) {
> -- 
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>