linux-kernel - Re: [PATCH 3/7] efi: Add SHIM and image security database GUID definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170207075219.GB24528@gmail.com>
Date:   Tue, 7 Feb 2017 08:52:20 +0100
From:   Ingo Molnar <mingo@...nel.org>
To:     Ard Biesheuvel <ard.biesheuvel@...aro.org>
Cc:     matt@...eblueprint.co.uk, Thomas Gleixner <tglx@...utronix.de>,
        "H . Peter Anvin" <hpa@...or.com>,
        David Howells <dhowells@...hat.com>,
        linux-kernel@...r.kernel.org, linux-efi@...r.kernel.org,
        Josh Boyer <jwboyer@...oraproject.org>
Subject: Re: [PATCH 3/7] efi: Add SHIM and image security database GUID
 definitions


* Ard Biesheuvel <ard.biesheuvel@...aro.org> wrote:

> From: David Howells <dhowells@...hat.com>
> 
> Add the definitions for shim and image security database, both of which
> are used widely in various Linux distros.
> 
> Signed-off-by: Josh Boyer <jwboyer@...oraproject.org>
> Signed-off-by: David Howells <dhowells@...hat.com>
> Cc: Matt Fleming <matt@...eblueprint.co.uk>
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@...aro.org>

That's not a valid SOB chain: the SOB of the author of the patch (David Howells) 
must come first.

I changed it to:

  Signed-off-by: David Howells <dhowells@...hat.com>
  Acked-by: Josh Boyer <jwboyer@...oraproject.org>
  Cc: Matt Fleming <matt@...eblueprint.co.uk>
  Signed-off-by: Ard Biesheuvel <ard.biesheuvel@...aro.org>

Please holler if that's not OK.

Thanks,

	Ingo