linux-kernel - Re: [PATCH 5/5] regulator: core: lower severity level of message about using dummy supplies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 6 Feb 2017 16:56:55 -0800
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Mark Brown <broonie@...nel.org>
Cc:     Liam Girdwood <lgirdwood@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/5] regulator: core: lower severity level of message
 about using dummy supplies

On Sun, Feb 05, 2017 at 05:12:46PM +0100, Mark Brown wrote:
> On Sat, Feb 04, 2017 at 09:45:02AM -0800, Dmitry Torokhov wrote:
> > On Sat, Feb 04, 2017 at 12:48:19PM +0100, Mark Brown wrote:
> 
> > > It really shouldn't be either of these things, at least on DT systems.
> 
> > But it definitely happens on ACPI systems for drivers for peripherals
> > that we share between both x86 and ARM.
> 
> Something that makes the warning informational only on ACPI systems
> would be fine.

I can definitely select the severity based on acpi_disabled flag, but I
think you should reconsider: from what I have seen in the kernel quite a
few driversi, even OF-specific ones, select regulator_get_optional() for
no good reason other than to avoid this "scary" warning. If its severity
were reduced quite a few drivers could be switched to normal
regulator_get().

Candidates for conversion (not complete, just examples):

drivers/input/touchscreen/zforce_ts.c
drivers/input/touchscreen/tsc200x-core.c
drivers/power/avs/rockchip-io-domain.c
drivers/mfd/stmpe.c

... and more...

Thanks.

-- 
Dmitry