linux-kernel - [PATCH] scsi: aacraid: rcode is unsigned, so can never be less than zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170207112738.18486-1-colin.king@canonical.com>
Date:   Tue,  7 Feb 2017 11:27:38 +0000
From:   Colin King <colin.king@...onical.com>
To:     Adaptec OEM Raid Solutions <aacraid@...rosemi.com>,
        "James E . J . Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K . Petersen" <martin.petersen@...cle.com>,
        linux-scsi@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] scsi: aacraid: rcode is unsigned, so can never be less than zero

From: Colin Ian King <colin.king@...onical.com>

The check on rcode >= 0 is always true because rcode is unsigned
and can never be less than zero.  Remove the redundant check.

Signed-off-by: Colin Ian King <colin.king@...onical.com>
---
 drivers/scsi/aacraid/aachba.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/aacraid/aachba.c b/drivers/scsi/aacraid/aachba.c
index 3b5ddf4..ddfd726 100644
--- a/drivers/scsi/aacraid/aachba.c
+++ b/drivers/scsi/aacraid/aachba.c
@@ -1848,7 +1848,7 @@ int aac_report_phys_luns(struct aac_dev *dev, struct fib *fibptr, int rescan)
 			FsaNormal, 1, 1, NULL, NULL);
 
 	/* analyse data */
-	if (rcode >= 0 && phys_luns->resp_flag == 2) {
+	if (phys_luns->resp_flag == 2) {
 		/* ok and extended reporting */
 		aac_update_hba_map(dev, phys_luns, rescan);
 	}
-- 
2.10.2