linux-kernel - Re: [PATCH] arm64: kconfig: allow support for memory failure handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87k292yzr9.fsf@e105922-lin.cambridge.arm.com>
Date:   Tue, 07 Feb 2017 12:03:06 +0000
From:   Punit Agrawal <punit.agrawal@....com>
To:     "Baicar\, Tyler" <tbaicar@...eaurora.org>
Cc:     catalin.marinas@....com, will.deacon@....com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        "Jonathan \(Zhixiong\) Zhang" <zjzhang@...eaurora.org>
Subject: Re: [PATCH] arm64: kconfig: allow support for memory failure handling

"Baicar, Tyler" <tbaicar@...eaurora.org> writes:

> Hello Punit,
>
>
> On 2/3/2017 9:27 AM, Punit Agrawal wrote:
>> Tyler Baicar <tbaicar@...eaurora.org> writes:
>>
>>> From: "Jonathan (Zhixiong) Zhang" <zjzhang@...eaurora.org>
>>>
>>> If ACPI_APEI and MEMORY_FAILURE is configured, select
>>> ACPI_APEI_MEMORY_FAILURE. This enables memory failure recovery
>>> when such memory failure is reported through ACPI APEI. APEI
>>> (ACPI Platform Error Interfaces) provides a means for the
>>> platform to convey error information to the kernel.
>>>
>>> Declare ARCH_SUPPORTS_MEMORY_FAILURE, as arm64 does support
>>> memory failure recovery attempt.
>>>
>>> Signed-off-by: Jonathan (Zhixiong) Zhang <zjzhang@...eaurora.org>
>>> Signed-off-by: Tyler Baicar <tbaicar@...eaurora.org>
>>> ---
>>>   arch/arm64/Kconfig | 2 ++
>>>   1 file changed, 2 insertions(+)
>>>
>>> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
>>> index f92778d..4cd12a0 100644
>>> --- a/arch/arm64/Kconfig
>>> +++ b/arch/arm64/Kconfig
>>> @@ -15,6 +15,8 @@ config ARM64
>>>   	select ARCH_HAS_SG_CHAIN
>>>   	select ARCH_HAS_TICK_BROADCAST if GENERIC_CLOCKEVENTS_BROADCAST
>>>   	select ARCH_USE_CMPXCHG_LOCKREF
>>> +	select ACPI_APEI_MEMORY_FAILURE if ACPI_APEI && MEMORY_FAILURE
>>> +	select ARCH_SUPPORTS_MEMORY_FAILURE
>> Although enabling support for memory failure handling makes sense in the
>> architecture config, it feels out of place to select
>> ACPI_APEI_MEMORY_FAILURE here.
>>
>> Maybe key it off of CONFIG_APEI?
> Yes, I can move it there.
>
> config ACPI_APEI
>         bool "ACPI Platform Error Interface (APEI)"
>         select MISC_FILESYSTEMS
>         select PSTORE
>         select UEFI_CPER
> +        select ACPI_APEI_MEMORY_FAILURE if MEMORY_FAILURE
>         depends on HAVE_ACPI_APEI
>

That's what I was suggesting - we'll see what the ACPI maintainers think
of the change.

> The ARCH_SUPPORTS_MEMORY_FAILURE should remain in arch/arm64/Kconfig
> though, correct?

Yes, that's right - as that's a feature the architecture is advertising
support for, it should stay in the arm64 Kconfig,

>
> Thanks,
> Tyler